Do not check assembly symbols equality by DefinitionRange and name #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assembly symbols have startup definition range and considered equal. Fixes dotnet#4658.
auduchinok
force-pushed
the
assembly-symbols-defnEq-fix
branch
from
ff6269b to
0c7c3bc
Compare
|
@dsyme Is it a good idea to have such definition ranges for symbols and rely on it this way at all? |
auduchinok
force-pushed
the
assembly-symbols-defnEq-fix
branch
from
ec8bd98 to
2949028
Compare
|
Any plans to merge this? It's ready for a month. |
dsyme
approved these changes
May 29, 2018
|
We can merge this but we should first re-test once IDE tests are re-enabled I suppose |
|
cc @KevinRansom |
auduchinok
added a commit
to auduchinok/fsharp
that referenced
this pull request
Mar 21, 2019
…otnet#4662) * Do not check assembly symbols equality by DefinitionRange and name Assembly symbols have startup definition range and considered equal. Fixes dotnet#4658. * Add test for equality of entities from assemblies with the same name * Add checks for range0 and rangeCmdArgs ranges * Do not run new tests on netcoreapp2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assembly symbols have
startupdefinition range and are considered equal whenLogicalNameequals.We should not check this range for assembly symbols, as a proper check is done just before.
Fixes #4658.