Make enum cases public #5002
Merged
Make enum cases public #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KevinRansom
commented
May 25, 2018
KevinRansom
commented
- Current F# Code generation for internal Enums makes the cases internal. This PR aligns our code gen with C# by generating Enum Cases that are public, under all conditions.
added 2 commits
May 24, 2018 17:44
dsyme
reviewed
May 25, 2018
| IsHiddenRecdField eenv.sigToImplRemapInfo (tcref.MakeNestedRecdFieldRef fspec)) | ||
| let isPropHidden = | ||
| // Enums always have public cases irrespective of Enum Visibility | ||
| if tycon.IsEnumTycon then false |
There was a problem hiding this comment.
The value__ field in enums should always be private, I think this will have changed?.
Also we need to have a CodeGen test for enums...
There was a problem hiding this comment.
Yes I expect it will. I can fix those.
There was a problem hiding this comment.
dsyme
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.