Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase lexer identifier dictionary initial capacity to reduce resizing #5089

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Increase lexer identifier dictionary initial capacity to reduce resizing #5089

merged 1 commit into from
Jun 12, 2018

Conversation

vasily-kirichenko
Copy link
Contributor

Change something in TypeChecker.fs, wait for CPU idle.

Before

image

After

image

@forki
Copy link
Contributor

forki commented Jun 5, 2018

how do we find the correct value?

@vasily-kirichenko
Copy link
Contributor Author

@forki It clearly depends on the number of unique identifier token in a file. For TypeChecker.fs, 100 is too small, 1024 works ok. I'm not sure it 1024 is a too much value to worry about memory usage.

@vasily-kirichenko
Copy link
Contributor Author

Ping

@cartermp
Copy link
Contributor

@KevinRansom / @brettfo / @TIHan we should take this for 15.8

@KevinRansom KevinRansom merged commit bb33e27 into dotnet:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsyme dsyme dsyme approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vasily-kirichenko @forki @cartermp @dsyme @KevinRansom