Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create packages using build-assigned version number #5179

Merged
merged 1 commit into from
Jun 12, 2018
Merged

create packages using build-assigned version number #5179

merged 1 commit into from
Jun 12, 2018

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Jun 12, 2018

Official build numbers are UTC for reasons outside of our control so we could get into a situation where a build queued late enough in the day would create NuGet packages with a date of n, having been calculated from here but the assembly versions would have a version of n+1 calculated from the BUILD_BUILDNUMBER environment variable from here (which correctly falls back to DateTime.Now if no build number was specified.)

@brettfo brettfo requested a review from KevinRansom June 12, 2018 19:31
@KevinRansom KevinRansom merged commit c16807e into dotnet:master Jun 12, 2018
@brettfo brettfo deleted the nuget-package-version branch June 12, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants