Dev16 fixes - cross project referencing #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsintegration/src/FSharp.Editor/LanguageService/LegacyProjectWorkspaceMap.fs
Outdated
Show resolved
Hide resolved
vsintegration/src/FSharp.Editor/LanguageService/LegacyProjectWorkspaceMap.fs
Outdated
Show resolved
Hide resolved
vsintegration/src/FSharp.Editor/LanguageService/LegacyProjectWorkspaceMap.fs
Outdated
Show resolved
Hide resolved
|
@KevinRansom @cartermp @Pilchie This is ready. We really need to get this in preview 1 because right now all cross project referencing for F# does not work at all in dev16 preview 1 without these major changes. |
cartermp
reviewed
Oct 30, 2018
| @@ -206,7 +206,7 @@ type internal FSharpLanguageService(package : FSharpPackage, solution: IVsSoluti | |||
| let projectDisplayName = projectDisplayNameOf projectFileName | |||
| Some (workspace.ProjectTracker.GetOrCreateProjectIdForPath(projectFileName, projectDisplayName)) | |||
|
|
|||
| let mutable legacyProjectWorkspaceMap = Unchecked.defaultof<LegacyProjectWorkspaceMap> | |||
| let _legacyProjectWorkspaceMap = new LegacyProjectWorkspaceMap(solution, projectInfoManager, package.ComponentModel.GetService<IWorkspaceProjectContextFactory>()) | |||
There was a problem hiding this comment.
Because I just need to make an instance of it and hold it. Internally, it subscribes to events that we care about.
|
@KevinRansom @dsyme @cartermp I really a review for this soon, because this needs to get in preview 1. |
KevinRansom
approved these changes
Nov 1, 2018
| [<AutoOpen>] | ||
| module private FSharpProjectOptionsHelpers = | ||
|
|
||
| let mapCpsProjectToSite(workspace:VisualStudioWorkspaceImpl, project:Project, serviceProvider:System.IServiceProvider, cpsCommandLineOptions: IDictionary<ProjectId, string[] * string[]>) = |
There was a problem hiding this comment.
This looks like a refactor of, do we still use the original?
There was a problem hiding this comment.
We don't use the original. But in my second PR: #5845 - ProjectSitesAndFiles.fs get completely removed.
cartermp
approved these changes
Nov 2, 2018
KevinRansom
approved these changes
Nov 12, 2018
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Trying to fix dev16 with latest changes * Dev16 is partially working * Fixed several issues, should be working dev16 * Using try..with on computing options * Deleting unused code * Minor refactor * Check command line option cps stamps for recompute as a backup * Using ProjectId for project options * Updating binoutputpath for legacy projects to workspace project * Removing cps stamp as we don't need it * Updated roslyn package. Using IWorkspaceProjectContext.Id. * update to Roslyn d16p1 packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a lot. In order to react to the dev16 changes, we needed to take an entirely different approach to computing options. Essentially, we compute the options whenever one of the analyzer first ask for it.