-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev16 Preview2]Single File Management Refactor #5845
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3944a88
Trying to fix dev16 with latest changes
TIHan 9a6bb62
Dev16 is partially working
TIHan e5b98f8
Fixed several issues, should be working dev16
TIHan 2ea60a7
Using try..with on computing options
TIHan 3e85e8b
Deleting unused code
TIHan 3d633bb
Minor refactor
TIHan 736bf3a
Check command line option cps stamps for recompute as a backup
TIHan d05af2e
Using ProjectId for project options
TIHan 415bdbb
Updating binoutputpath for legacy projects to workspace project
TIHan f4e0c88
Removing cps stamp as we don't need it
TIHan 8169490
Updated roslyn package. Using IWorkspaceProjectContext.Id.
TIHan a099e6d
Handling single files (script files) differently
TIHan c7ead94
Removing dead code
TIHan ca4e2a9
Removing dead code
TIHan 557d281
Removing dead code
TIHan 5b9e6dd
Removing dead code
TIHan 5d0e105
Removing dead code
TIHan a45274c
Removing ProjectSitesAndFiles.fs
TIHan 61c976b
Initializing early to capture solution/workspace events
TIHan d50fce6
Handling rename of script files
TIHan ac0a91d
Merged into dev16
TIHan 671e7aa
Delete Fsi.nuget.props
TIHan 9b49622
Update Extensions.fs
TIHan 44bf2a4
Create project per script file
TIHan 13f579c
Make sure to dispose in fallback
TIHan ded440f
Don't need that
TIHan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TIHan I don't understand this change in dev16.
#10156 is a synchronous call to this on the UI thread
As the comment to this method says, the point of "TryGetOptionsForEditingDocumentOrProject" is to get editing options quickly for scripts, in the cases where we need them fast on the UI thread for editing operations. But this change removed this and now this method computed the exact options.
I believe this is a primary cause for slower script editing in dev16, e.g. #6646, and is related to the UI thread aspects of #8757
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back, I don't think I understood this well enough at the time and made the change in hopes to normalize everything.
If this call was being invoked on the UI thread somewhere, I can totally understand why there would be a performance issue.