-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing addNewLine #5941
Removing addNewLine #5941
Conversation
Fixes #3617. |
Some of the other tests here are harder to fix... |
Sweet, only 82 tests left. They're in the legacy langauge service tests, making it extra fun! |
* Update interactivechecker and structure tests * Try to fix some legacy tests
Okay, so this change definitely breaks completion. Everything else seems fine, so there's something about completion that requires a newline at the end of the file... |
The "break" is actually just a breaking change from a newer API that was then removed in dev16. Unrelated to this PR. |
* Update interactivechecker and structure tests * Try to fix some legacy tests * More test fixes
Blegh it won't be as easy as I thought then. These old tests are horribly complex 😢 |
Just posting this for my amusement before going to bed. FCS says we need a newline because of tests: Tests say we need to do something because FCS adds a new line: Tests also say that FCS adds three new lines, hence a So FCS does something because of tests, and tests do something because of FCS. But what's actually bothering me the most is this: (testLines.Length-1)+1 Time for bed. |
Closing as this PR resolves it: #6001 |
This removes addNewLine. It appended an entire source string with "\n" causing massive allocations for large source files.