Fix missing completion items in constructors of inherited types #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate PR |
cartermp
reviewed
Dec 11, 2018
auduchinok
changed the title
|
@dsyme Is this approach correct in general? I'm concerned if there're other cases where an FSharpSymbol is created with |
dsyme
approved these changes
Jan 9, 2019
vikaskyadav
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3699. The inner env produced for the base type constructor was preferred in
TypeCheckInfo.GetBaseEnvForPosdue to having a nested range making parameters from the primary constructor unavailable in the base constructor call anddoexpressions.The completion tests code is awfully repeated, should I clean it up in a separate PR or doing it in this PR would be OK?