Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4946 --- Update FSC and FSI to recognize upto .net framework 472 #6005

Merged
merged 4 commits into from
Dec 14, 2018

Conversation

KevinRansom
Copy link
Member

Fixes #4946

I note that Don submitted a similar PR, however this one as well as enabling the higher frameworks. Updates the HighestInstalledNetFrameworkVersion api, to return the highest supported framework.

/cc @brettfo This fixes the issue we were seeing with Dev 16.0

@dsyme
Copy link
Contributor

dsyme commented Dec 13, 2018

Failing codegen test (System.ValueTuple now in mscorlib)

2018-12-13T06:24:25.1698042Z +++ CodeGen\EmittedIL\Tuples (ValueTupleAliasConstructor.fs -) +++

Also FCS is failing to build due to some undefined symbols

@dsyme
Copy link
Contributor

dsyme commented Dec 13, 2018

@KevinRansom As we discussed I think we can move FCS to .NET 4.7.2 for dev 16.0 timeframe

@auduchinok
Copy link
Member

@dsyme Is net472 really needed?
We still target net461. I'll try to figure out if we're going to move anytime soon.

@dsyme
Copy link
Contributor

dsyme commented Dec 13, 2018

@dsyme Is net472 really needed? We still target net461. I'll try to figure out if we're going to move anytime soon.

Thanks, this is useful feedback.

My understanding is dev16.0 will take .NET 4.7.2 as a base but others can confirm.

@KevinRansom If we can get this PR in with FCS still target net461 that would be great.

@brettfo
Copy link
Member

brettfo commented Dec 13, 2018

I've already done something similar when we ported the dev16.0 branch to net472 in #5719.

@KevinRansom KevinRansom force-pushed the fixes4946 branch 2 times, most recently from c6546c9 to 542436e Compare December 14, 2018 03:59
@KevinRansom
Copy link
Member Author

Okay so I updated this so that:

  1. Versions below DotNET 4.5 are no longer recognized
  2. It searches for reference assembly profiles and selects the highest version.
  3. If No reference assemblies are installed it uses the highest framework.

@KevinRansom KevinRansom requested a review from brettfo December 14, 2018 19:59
@brettfo brettfo merged commit 2277eb2 into dotnet:master Dec 14, 2018
@KevinRansom KevinRansom deleted the fixes4946 branch February 28, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSI and FSC default to at most .NET Framework 4.6.1, missing .NET 4.6.2/4.7/4.7.1/4.7.2
4 participants