-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4946 --- Update FSC and FSI to recognize upto .net framework 472 #6005
Conversation
Failing codegen test (System.ValueTuple now in mscorlib)
Also FCS is failing to build due to some undefined symbols |
@KevinRansom As we discussed I think we can move FCS to .NET 4.7.2 for dev 16.0 timeframe |
@dsyme Is net472 really needed? |
Thanks, this is useful feedback. My understanding is dev16.0 will take .NET 4.7.2 as a base but others can confirm. @KevinRansom If we can get this PR in with FCS still target net461 that would be great. |
I've already done something similar when we ported the |
c6546c9
to
542436e
Compare
Okay so I updated this so that:
|
60591cd
to
b6815e4
Compare
Fixes #4946
I note that Don submitted a similar PR, however this one as well as enabling the higher frameworks. Updates the HighestInstalledNetFrameworkVersion api, to return the highest supported framework.
/cc @brettfo This fixes the issue we were seeing with Dev 16.0