Fixed signature help with tuple arg on one line #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
changed the title
6 tasks
TIHan
changed the title
cartermp
approved these changes
Feb 6, 2019
KevinRansom
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When typing this code with only one line in the text buffer:
let _ = System.DateTime(1L,on the
,it will trigger signature help. This currently works in master and Dev16 in VS.However, with this PR, #6001, it will break due to removing the
addNewLineand we had a bug in the lang service and parser that forced the additionaladdNewLineto make everything correct.This PR will solve that problem whenever #6001 is merged.