Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug fixes #6170

Merged
merged 2 commits into from
Feb 19, 2019
Merged

debug fixes #6170

merged 2 commits into from
Feb 19, 2019

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jan 31, 2019

I noticed a few problems while running VisualFSharp tools in debug mode on some F# scripts. These fixes don't affect the actual product behaviour

  1. We are getting an assert in the MSBuild resolution while processing scripts. The problem is that old broken code to compute the target framework version is kicking in and evaluating to "v4.0" which is no longer even supported. This computation of target framework version is only relevant in secondary stages of processing scripts and should just be HighestInstalledFrameworkVersion

  2. The Simulated MSBuild code was failing if the gac directory does not exist. This code is only used by FCS. and was only failing for the .NET Standard/Core version of FCS This is now protected bya Directory.Exists

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ass removal

src/fsharp/SimulatedMSBuildReferenceResolver.fs Outdated Show resolved Hide resolved
src/fsharp/SimulatedMSBuildReferenceResolver.fs Outdated Show resolved Hide resolved
src/fsharp/SimulatedMSBuildReferenceResolver.fs Outdated Show resolved Hide resolved
src/fsharp/SimulatedMSBuildReferenceResolver.fs Outdated Show resolved Hide resolved
src/fsharp/SimulatedMSBuildReferenceResolver.fs Outdated Show resolved Hide resolved
@KevinRansom
Copy link
Member

@dsyme

        /home/vsts/work/1/s/src/fsharp/CompileOps.fs(2792,9): error FS1182: The value 'ilGlobals' is unused [/home/vsts/work/1/s/fcs/FSharp.Compiler.Service/FSharp.Compiler.Service.fsproj]
2019-01-31T13:48:56.1556589Z 

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are passing this is fine.

@dsyme dsyme merged commit 7376e22 into dotnet:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants