Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Data.SqlClient #6274

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Remove System.Data.SqlClient #6274

merged 2 commits into from
Feb 22, 2019

Conversation

KevinRansom
Copy link
Member

The System.Data.SqlClient was to get some FSI tests that pass on desktop, to similarly pass on coreclr.

Let's figure out what's broken with out it, and see if this is the right fix!

Kevin

@KevinRansom KevinRansom mentioned this pull request Feb 22, 2019
Closed
@KevinRansom KevinRansom reopened this Feb 22, 2019
@KevinRansom KevinRansom changed the title [WIP] Investigate SqlClient Remove System.Data.SqlClient Feb 22, 2019
@KevinRansom
Copy link
Member Author

@dsyme, @cartermp apparently it's not need at all.

All tests pass with it removed.

Fixes: #6273

@KevinRansom KevinRansom merged commit 2c8497b into dotnet:master Feb 22, 2019
@KevinRansom KevinRansom deleted the investigatesqlclient branch February 28, 2019 04:28
@nguerrera nguerrera mentioned this pull request May 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettfo brettfo brettfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinRansom @brettfo