Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in August we renamed Embed to EmbeddedFiles, this Build Property is used to specify to the build task what source files to embed in the PDB. The property was renamed to align with the C# BuildTask since we did it first this seems slightly unfair, but hey …
However, there is a nasty side effect that sometimes now shows up. Msbuild has a habit of re-using loaded assemblies, so it is possible for some solutions to actually use different versions of the F# compiler depending on installed versions, paths, etc.
This causes us to see occasionally under hard to diagnose circumstances, this error:
The Fix here is to make the build task now support both Embed and EmbeddedFiles, so that now whichever Microsoft.FSharp.Targets file is in use we end up being able to support the property.
Also, we are switching back to using the old Task-property in Microsoft.FSharp.Targets, so that if the old build task was loaded first then it's will be used.
We will use the msbuild property EmbeddedFiles as input to the Embed buildtask property so that our project files look like the C# ones.
/cc @dsyme, @cartermp, brettfo
Kevin