Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC FS-1070] relax indentations for static members and constructors #6314

Closed
wants to merge 27 commits into from

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Mar 9, 2019

This is the implementation of RFC FS-1070 - Offside relaxations

This permits undentation in these situations:

type OffsideCheck(a:int,
        b:int, c:int, // no warning
        d:int) =
    static member M(a:int,
        b:int, c:int, // no warning
        d:int) = 1

type C() = 
    static member P with get() = 
      1 // no warning

cc @charlesroddie @cartermp

@charlesroddie - Any chance you can write up a brief RFC for this?

@dsyme dsyme closed this Mar 9, 2019
@dsyme dsyme reopened this Mar 9, 2019
@dsyme
Copy link
Contributor Author

dsyme commented Mar 9, 2019

Dodgy test

[xUnit.net 00:02:46.32]     FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.CancellationType.AwaitTaskCancellationAfterAsyncTokenCancellation [FAIL]
Failed   FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.CancellationType.AwaitTaskCancellationAfterAsyncTokenCancellation
Error Message:
 NUnit.Framework.AssertionException : Exception of type 'NUnit.Framework.AssertionException' was thrown.
Stack Trace:
   at FSharp.Core.UnitTests.FSharp_Core.Microsoft_FSharp_Control.CancellationType.AwaitTaskCancellationAfterAsyncTokenCancellation() in D:\a\1\s\tests\FSharp.Core.UnitTests\FSharp.Core\Microsoft.FSharp.Control\Cancellation.fs:line 283
Ok, passed 100 tests.

@dsyme dsyme closed this Mar 10, 2019
@dsyme dsyme reopened this Mar 10, 2019
@dsyme
Copy link
Contributor Author

dsyme commented Mar 10, 2019

Dodgy test. This one is failing a bit too often for my liking (though obviously sometimes succeeding)

Failed   TypeProvider.Disposal.SmokeTest2
Error Message:
 System.Reflection.TargetInvocationException : Exception has been thrown by the target of an invocation.
  ----> System.Exception : expected configuration object to be disposed
Stack Trace:

@dsyme dsyme closed this Mar 11, 2019
@dsyme dsyme reopened this Mar 11, 2019
@dsyme dsyme closed this Mar 11, 2019
@dsyme dsyme reopened this Mar 11, 2019
@dsyme dsyme changed the title [RFC required] relax indentations for static members and constructors [Needs RFC] relax indentations for static members and constructors Mar 12, 2019
@dsyme
Copy link
Contributor Author

dsyme commented Mar 12, 2019

@dsyme dsyme removed the Needs-RFC label Mar 12, 2019
@dsyme dsyme changed the title [Needs RFC] relax indentations for static members and constructors [RFC FS-1070] relax indentations for static members and constructors Mar 12, 2019
@dsyme dsyme closed this Mar 12, 2019
@dsyme dsyme reopened this Mar 12, 2019
@dsyme
Copy link
Contributor Author

dsyme commented May 22, 2019

Closing in favour of #6808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants