update FCS dependencies #6388

dsyme · 2019-03-28T12:01:44Z

This updates the FCS dependencies to

.NET 4.5 --> .NET 4.6.1
FSharp.Core 4.5.2. --> FSharp.Core 4.6.2

auduchinok

I think FCS readme, which claims net45 and FSharp.Core 4.0.0.0 are referenced, needs updating too.

auduchinok · 2019-03-28T12:27:42Z

fcs/docsrc/content/react.fsx

@@ -19,7 +19,7 @@ referenced DLLs may change on disk, or referenced files may change.
 The ``FSharpChecker`` component from FSharp.Compiler.Service does _not_ actively "listen"
 to changes in the file system.  However ``FSharpChecker`` _does_ repeatedly ask for
 time stamps from the file system which it uses to decide if recomputation is needed.
-FCS doesn�t listen for changes directly - for example, it creates no ``FileWatcher`` object (and the
+FCS doesn�t listen for changes directly - for example, it creates no ``FileWatcher`` object (and the


Something is wrong with encoding.

auduchinok · 2019-03-28T12:28:21Z

fcs/RELEASE_NOTES.md

@@ -1,3 +1,6 @@
+#### 23.0.1


Shouldn't it be something like 28.0.0 already?

Yes, changes need to be RI'd back from FCS repository. I'll ask @baronfel to help with that, thanks

I'll take care of that when this merges is integrated, so as to not cause conflicts.

auduchinok · 2019-03-28T13:13:57Z

fcs/docsrc/content/react.fsx

@@ -33,7 +33,7 @@ stays up-to-date when changes are observed.

 If you want to more actively listen for changes, then you should add watchers for the
 files specified in the ``DependencyFiles`` property of ``FSharpCheckFileResults`` and ``FSharpCheckProjectResults``.
-Here�s what you need to do: 
+Here�s what you need to do: 


Another few encoding problems here and below.

cartermp · 2019-03-28T13:44:15Z

What's the rationale for the change here?

dsyme · 2019-03-28T15:50:36Z

What's the rationale for the change here?

Nothing definite but "it's probably time to do this". (Well, OK, I noticed again that we couldn't use latest FSharp.Core functions, hence the FSharp.Core update, but it's not critical)

There's no real criteria except that the dependencies must be low enough to allow FCS to be used in sufficiently wide circumstances for the various applications that consume it to be happy.

Happy to take advice from FCS users on whether the dependencies are ok

dsyme · 2019-03-28T15:54:04Z

I'll take care of that when this merges is integrated, so as to not cause conflicts.

@baronfel Please also RI any changes from FCS repo back here from time to time, thanks

cartermp · 2019-03-28T16:01:25Z

Are there any #if net461 or lower versions in the code for FCS? If not, it can just target netstandard. No need to have a .NET Framework target if we're fine with net461 as the base .NET Framework version for non-core and non-mono consumers (which I am fine with, since that's been the base for VS since early 2017 and has likely proliferated across the ecosystem)

auduchinok · 2019-03-28T16:03:51Z

Happy to take advice from FCS users on whether the dependencies are ok

From the top of my head: it'll allow using things like EmptyArray in FCS if we try to replace F# lists with arrays in some places.

We'll need to updates some clients like Fantomas but I share the "it's probably time" feeling.

dsyme · 2019-03-28T16:07:42Z

Are there any #if net461 or lower versions in the code for FCS? If not, it can just target netstandard.

Only .NET 4.7.2+ supported netstandard properly IIRC. Also our NETSTANDARD build may vary slightly

Suggest we go to .NET 4.6.1 for now then deal with moving fully to netstandard2.0 separately

cartermp · 2019-03-28T16:19:19Z

Only .NET 4.7.2+ supported netstandard properly IIRC

It depends. Up until net472 some type forwards are wrong, but most aren't. So if the APIs we use are type forwarded correctly, there's no issue.

nightroman · 2019-03-30T15:58:30Z

Was the change from net45 to net461 necessary? The latest FSharp.Core requires net45. Windows 8x (still in use) comes with net45x built-in. Windows 10 without updates comes with net46 (updates may not always be assumed).

NB I am not affected too much myself but I develop an OSS project using FCS and users may be affected. This worries me. Ideally, I expect FCS requirements to be aligned with FSharp.Core.

dsyme · 2019-03-31T14:03:02Z

Was the change from net45 to net461 necessary? The latest FSharp.Core requires net45. Windows 8x (still in use) comes with net45x built-in. Windows 10 without updates comes with net46 (updates may not always be assumed).

We have to move forward at some point. I think design-time tooling relying on .NET 4.5 is very very rare now. What's the tool you are working on?

dsyme · 2019-03-31T14:04:36Z

Ideally, I expect FCS requirements to be aligned with FSharp.Core.

I don't think this is right in general - there are runtime contexts for F# applications (FSharp.Core) and design-time contexts (F# compiler). FCS tools are nearly always design-time or some other form of immediate coding experience (e.g. REPL etc.)

nightroman · 2019-03-31T15:28:11Z

@dsyme Thank you.

Do not get me wrong, I am not against this. "Moving forward at some point" is the right thing as such.

I think design-time tooling relying on .NET 4.5 is very very rare now. What's the tool you are working on?

Correct, it's very rare for "development" environment. But when development is finished the result script tools are supposed to work in a portable app (Far Manager), on as much OS's as possible. I am working on FSharpFar, it's a plugin for Far Manager.

nightroman · 2019-03-31T15:33:03Z

I don't think this is right in general - there are runtime contexts for F# applications (FSharp.Core) and design-time contexts (F# compiler).

F# compiler is not just design time tool. It's the runner of finished script tools as well (runtime context).

cartermp · 2019-03-31T16:19:27Z

For the purposes of support we only consider it a design-time tool. That isn't to say we intentionally break scripts processing if it depends on a particular .NET Framework version, but we won't hold back a good enough change for that.

nightroman · 2019-03-31T16:48:48Z

I am not arguing. But please do not treat F# scripts as development toys. They are F#-app-like tools, too.

dsyme · 2019-04-01T12:25:13Z

I am not arguing. But please do not treat F# scripts as development toys. They are F#-app-like tools, too.

Thanks for the perspective, that's helpful.

Anyway, I think .NET 4.6.1 is OK for FCS latest. If .NET 4.5 is required then the application can probably sit on an earlier FCS (hence only support F# 4.5, but that's likely ok)

nightroman · 2019-04-01T12:37:07Z

hence only support F# 4.5, but that's likely ok

Just for information, FWIW, I used FSharp.Core 4.6.x with previous FCS 27.x with no problems.

dsyme added 2 commits March 28, 2019 12:00

update FCS dependencies

1f8918d

update FCS dependencies

8b336e7

auduchinok reviewed Mar 28, 2019

View reviewed changes

dsyme added 2 commits March 28, 2019 12:31

fix up build

1cd2401

code review

b9883a0

auduchinok approved these changes Mar 28, 2019

View reviewed changes

KevinRansom approved these changes Mar 29, 2019

View reviewed changes

KevinRansom merged commit f1aee5f into dotnet:master Mar 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update FCS dependencies #6388

update FCS dependencies #6388

dsyme commented Mar 28, 2019

auduchinok left a comment

auduchinok Mar 28, 2019

auduchinok Mar 28, 2019

dsyme Mar 28, 2019

baronfel Mar 28, 2019 •

edited

Loading

auduchinok Mar 28, 2019

cartermp commented Mar 28, 2019

dsyme commented Mar 28, 2019 •

edited

Loading

dsyme commented Mar 28, 2019

cartermp commented Mar 28, 2019

auduchinok commented Mar 28, 2019

dsyme commented Mar 28, 2019 •

edited

Loading

cartermp commented Mar 28, 2019

nightroman commented Mar 30, 2019 •

edited

Loading

dsyme commented Mar 31, 2019

dsyme commented Mar 31, 2019

nightroman commented Mar 31, 2019

nightroman commented Mar 31, 2019 •

edited

Loading

cartermp commented Mar 31, 2019

nightroman commented Mar 31, 2019

dsyme commented Apr 1, 2019

nightroman commented Apr 1, 2019

update FCS dependencies #6388

update FCS dependencies #6388

Conversation

dsyme commented Mar 28, 2019

auduchinok left a comment

Choose a reason for hiding this comment

auduchinok Mar 28, 2019

Choose a reason for hiding this comment

auduchinok Mar 28, 2019

Choose a reason for hiding this comment

dsyme Mar 28, 2019

Choose a reason for hiding this comment

baronfel Mar 28, 2019 • edited Loading

Choose a reason for hiding this comment

auduchinok Mar 28, 2019

Choose a reason for hiding this comment

cartermp commented Mar 28, 2019

dsyme commented Mar 28, 2019 • edited Loading

dsyme commented Mar 28, 2019

cartermp commented Mar 28, 2019

auduchinok commented Mar 28, 2019

dsyme commented Mar 28, 2019 • edited Loading

cartermp commented Mar 28, 2019

nightroman commented Mar 30, 2019 • edited Loading

dsyme commented Mar 31, 2019

dsyme commented Mar 31, 2019

nightroman commented Mar 31, 2019

nightroman commented Mar 31, 2019 • edited Loading

cartermp commented Mar 31, 2019

nightroman commented Mar 31, 2019

dsyme commented Apr 1, 2019

nightroman commented Apr 1, 2019

baronfel Mar 28, 2019 •

edited

Loading

dsyme commented Mar 28, 2019 •

edited

Loading

dsyme commented Mar 28, 2019 •

edited

Loading

nightroman commented Mar 30, 2019 •

edited

Loading

nightroman commented Mar 31, 2019 •

edited

Loading