Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bad assembly name in attribute generation #6437

Merged
merged 1 commit into from
Apr 8, 2019
Merged

fix bad assembly name in attribute generation #6437

merged 1 commit into from
Apr 8, 2019

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 5, 2019 •
edited
Loading

The signed build failed saying there were issues with the auto-generated ProvideCodeBaseAttribute.

PR cannot be completed until:

@brettfo brettfo mentioned this pull request Apr 5, 2019
Merged
@brettfo brettfo force-pushed the fix-codebase branch 7 times, most recently from 41e9aa9 to d5e78e6 Compare April 5, 2019 20:49
@brettfo
Copy link
Member Author

brettfo commented Apr 6, 2019

@KevinRansom Can you look at the generated .pkgdef files to see if they're correct? You can find the VSIX here.

@brettfo brettfo mentioned this pull request Apr 6, 2019
Merged
@brettfo brettfo marked this pull request as ready for review April 6, 2019 23:05
@brettfo brettfo requested a review from KevinRansom April 6, 2019 23:05
KevinRansom
KevinRansom approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brettfo brettfo merged commit 45e9d7b into master Apr 8, 2019
@brettfo brettfo deleted the fix-codebase branch April 8, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettfo @KevinRansom