Update package, language, core and compiler tool versions #6526
Conversation
There was a problem hiding this comment.
Is there a reason to bump the FSharp.Core version? Aside from code cleanup there doesn't appear to be any meaningful differences https://github.com/Microsoft/visualfsharp/commits/master/src/fsharp/FSharp.Core
| @@ -13,7 +13,6 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="FSharp.Core" Version="4.6.2" /> | |||
| <PackageReference Include="FSharp.Core" Version="4.5.2" /> | |||
There was a problem hiding this comment.
Why is 4.5.2 being removed here?
There was a problem hiding this comment.
As you can see there are two package references. Clearly one is redundant.
There was a problem hiding this comment.
As for bumping the fsharp.core version 4.6.2 has already shipped, this is in preparation for shipping the next one. Which will likely happen when we ship a new compiler, in Dev 16.1
There was a problem hiding this comment.
4.5.2 removal makes sense here, but is it necessary (from a build process) to rev 4.6.2 with a new compiler if we're not shipping changes?
There was a problem hiding this comment.
@cartermp, this is in preparation for shipping the next FSharp.Core package. Whether we ship it on a particular date or note is a decision for then.
Update package, tool and language version numbers.
FSharp.Core package ==> 4.6.3
Microsoft.FSharp.Compiler ==> 10.4.3
FSharp tools banner ==> 10.4.3
Please note: Samples package references need to reflect already shipped versions.