Fix for anonymous record execution order #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests added, this is ready (once green) |
TIHan
reviewed
Apr 22, 2019
| @@ -6554,21 +6552,35 @@ let permuteExprList (sigma: int[]) (exprs: Expr list) (ty: TType list) (names: s | |||
| /// let sigma = Array.map #Index () | |||
| /// However the presence of static fields means .Index may index into a non-compact set of instance field indexes. | |||
| /// We still need to sort by index. | |||
| let mkRecordExpr g (lnk, tcref, tinst, rfrefs: RecdFieldRef list, args, m) = | |||
| let mkRecordExpr g (lnk, tcref, tinst, unsortedRecdFields: RecdFieldRef list, unsortedFieldExprs, m) = | |||
There was a problem hiding this comment.
Those are better names for sure.
TIHan
approved these changes
Apr 22, 2019
Yes, I wrote it so I could do a line-for-line comparison and eventually share, but figured it would obfuscate the code for this PR to actually share |
KevinRansom
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6487. Untested as yet, pushing through CI.