Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --pathmap #6609

Merged
merged 11 commits into from
Apr 24, 2019
Merged

Conversation

saul
Copy link
Contributor

@saul saul commented Apr 22, 2019

Fixes #5213, #3812

Supersedes #5801

@saul saul mentioned this pull request Apr 22, 2019
@saul
Copy link
Contributor Author

saul commented Apr 22, 2019

cc @brettfo can you take a look at this PR instead?

@cartermp cartermp added the Ready label Apr 22, 2019
@cartermp cartermp closed this Apr 23, 2019
@cartermp cartermp reopened this Apr 23, 2019
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@KevinRansom
Copy link
Member

@saul

conflict ...

/help tests fail, baseline updates probably.

CompilerOptions\fsc\help (-?) -- failed
CompilerOptions\fsc\help (--help) -- failed
CompilerOptions\fsc\help (/?) -- failed

CompilerOptions\fsi\help (-?-40) -- failed
CompilerOptions\fsi\help (--help-40) -- failed
CompilerOptions\fsi\help (/?-40) -- failed
CompilerOptions\fsi\help (-? --nologo-40) -- failed

CompilerOptions\fsi\exename (-?-40) -- failed

A determinism test:
CompilerOptions\fsc\determinism (20) -- failed

@saul
Copy link
Contributor Author

saul commented Apr 23, 2019

Thanks @KevinRansom - I've just updated the baselines.

The determinism test (which I haven't changed) that failed is potentially flaky. In the env.lst, there is a comment stating: "we need to use the timeout because non-determinism in fsc is due to datetime, so we need to guarentee at least 1 sec difference"

...but there is no timeout/pause to ensure this gap as far as I can see?

@saul saul closed this Apr 23, 2019
@saul saul reopened this Apr 23, 2019
@saul
Copy link
Contributor Author

saul commented Apr 23, 2019

Re-running tests as it looks like Optimizations\Inlining (Match01.fs) is flaky (it also failed in a previous run). It looks like in some places, the lambda has changed name. For example, CompareTo$cont@4 vs CompareTo$cont@4-53.

@dsyme - any idea why the compiler is sometimes choosing different names? It actually seems important to determinism more widely.

@saul
Copy link
Contributor Author

saul commented Apr 23, 2019

Looks like a different flaky test now:

Failed   Automation.EnumDUInterfacefromFSBrowse.InsideMatch
Error Message:
 System.IO.IOException : The process cannot access the file 'D:\a\1\s\artifacts\tmp\Release\b9916641-ec81-40f0-b656-238061953256\testFile.fs' because it is being used by another process.
Stack Trace:
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.File.InternalDelete(String path, Boolean checkHost)
   at System.IO.File.Delete(String path)
   at <StartupCode$VisualFSharp-UnitTests>.$ProjectOptionsBuilder.System-IDisposable-Dispose@32.Invoke(Tuple`2 tupledArg) in D:\a\1\s\vsintegration\tests\UnitTests\ProjectOptionsBuilder.fs:line 32
   at Microsoft.FSharp.Primitives.Basics.List.iter[T](FSharpFunc`2 f, FSharpList`1 x) in D:\a\1\s\src\fsharp\FSharp.Core\local.fs:line 91
   at VisualFSharp.UnitTests.Roslyn.FSharpProject.System-IDisposable-Dispose() in D:\a\1\s\vsintegration\tests\UnitTests\ProjectOptionsBuilder.fs:line 32
   at Microsoft.VisualStudio.FSharp.Editor.Tests.Roslyn.QuickInfo.GetQuickInfoTextFromCode(String code) in D:\a\1\s\vsintegration\tests\UnitTests\QuickInfoTests.fs:line 45
   at Microsoft.VisualStudio.FSharp.Editor.Tests.Roslyn.QuickInfo.Automation.EnumDUInterfacefromFSBrowse.InsideMatch() in D:\a\1\s\vsintegration\tests\UnitTests\QuickInfoTests.fs:line 95

@saul saul closed this Apr 23, 2019
@saul saul reopened this Apr 23, 2019
@cartermp
Copy link
Contributor

It's green! Let's not sneeze in the wrong direction here, for fear of angering another flaky test...

@KevinRansom KevinRansom merged commit 3c77bae into dotnet:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature data embedded in executable contains absolute source file path
5 participants