Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev16.2 to fsharp5 #6664

Merged
14 commits merged into from
May 2, 2019
Merged

Merge dev16.2 to fsharp5 #6664

14 commits merged into from
May 2, 2019

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from dev16.2 into fsharp5.

git fetch --all
git checkout merges/dev16.2-to-fsharp5
git reset --hard upstream/fsharp5
git merge upstream/dev16.2
# Fix merge conflicts
git commit
git push upstream merges/dev16.2-to-fsharp5 --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

cartermp and others added 14 commits April 27, 2019 08:55
* Consolidate lots of info
* Add a quickstart so folks don't need to open the devguide for basic build/dev
* Remove lots of info that isn't about this repository at all
Co-Authored-By: cartermp <pcarter@fastmail.com>
…n error messages) (#6654)

* migrate (as a separate copy) fsharpqa tests that are going to be impacted by #6596

the baseline files are empty on purpose, expecting CI failure reporting those tests, I intend to update the baseline and clean up the comments / xml tags from fsharpqa syntax in later commit, and then remove those specific tests altogether from fsharpqa if this is OK with the maintainers.

* update the .bsl files

* remove comments that are handled by baseline files, update baseline files

* remove the migrated tests from fsharpqa tests

* need to be more careful when migrating those

* testing if running the test with .fs instead of .fsx makes them work on .netcore

* exclude migrated fsharpqa from dotnet core run
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit db9182f into fsharp5 May 2, 2019
@ghost ghost deleted the merges/dev16.2-to-fsharp5 branch May 2, 2019 01:30
@dotnet-bot dotnet-bot restored the merges/dev16.2-to-fsharp5 branch May 2, 2019 12:02
@dotnet-bot dotnet-bot deleted the merges/dev16.2-to-fsharp5 branch May 2, 2019 12:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants