Check constructor in FSharpMemberOrFunctionOrValue(SymbolEnv, MethInfo) #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
May 12, 2019
|
Are there test cases which show the difference in behaviour? thanks |
KevinRansom
approved these changes
May 13, 2019
|
@auduchinok it would be helpful, if you can add some tests. Kevin |
|
@dsyme @KevinRansom Sorry, it got merged before I read these comments. I'll add some tests as a part of #6711 or a separate PR. |
|
@auduchinok Thanks @KevinRansom Please make sure all adjustments to the behavior of the FCS API have tests before merging - especially those parts of the API which aren't exercised by the Visual F# Tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers few cases in FSharpMemberOrFunctionOrValue where MethInfo param can be a constructor.