Roslyn Shim - Round 2 #6734
Roslyn Shim - Round 2 #6734
Conversation
|
This is 99% done. Do not merge this in until Roslyn has merged theirs first. Still having some trouble getting DocumentDiagnosticAnalyzers to kick off. Once those are working and I do some testing, this will be 100% ready. |
|
Waiting for Roslyn's preview 4 branch. As soon as they have it, we update the package one more time. When Roslyn is ready to do an insertion, we merge and update the insertion with our bits. |
|
I spoke with @333fred and he pointed me to the Roslyn insertion into VS. I've updated |
|
Awaiting signed build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=2763846 |
* Added shims over document diagnostic analyzers * Shims over completions and sig help * Removed content type definitions, putting them in external access * Added shim over InlineRenameService * We are now simply using export on the diagnostic analyzers * Using shim for document highlights service * GoToDefinition implemented with shims * NavigableSymbolsService shimmed * GoToDefinitionService shimmed * NavigationBarItemService shimmmed * Shimmed NavigateToSearchService * Quick cast fix * Using FSharpGlyphTags * Removed CommentSelectionService as it is ExternalAccess now * Shimmed BlockStructureService * Trying to finish shim * Removed folder from FSharp.Editor * Update package * fixing build * Trying to fix build * match roslyn package version
Consuming the shim built in Roslyn, here -> dotnet/roslyn#35591 . That PR will actually remove most IVTs.
Still work in progress but want to make a PR to show the progress.