Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FSharp.Core to netstandard2.0 #6771

Closed
wants to merge 4 commits into from
Closed

Update FSharp.Core to netstandard2.0 #6771

wants to merge 4 commits into from

Conversation

KevinRansom
Copy link
Member

  1. FSharp.Core is updated to target netstandard2.0 as the minimum required platform.
  2. The FSharp.Core nuget package version 4.7.0, will contain net45 and netstandard2.0 dlls
    with the version number 4.7.0.0
  3. This PR enables the FSharpFunc API's that use the System.Converter class.
  4. Apparently the API Surface area tests have not been running, so I have re-enabled them, added back in the APIs that were missing. Some have moved around the baseline.

master will not be updated to a netstandard2.0 until after VS2019.2 has RTM'd

@KevinRansom KevinRansom requested review from brettfo and dsyme May 18, 2019 09:31
@cartermp
Copy link
Contributor

Link #1847

@brettfo
Copy link
Member

brettfo commented May 18, 2019

(@KevinRansom CI isn't setup for this branch, do you want me to add it?)

@KevinRansom
Copy link
Member Author

@brettfo, yes please.

@KevinRansom KevinRansom reopened this May 19, 2019
@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
cartermp
cartermp reviewed May 20, 2019
View reviewed changes
src/fsharp/FSharp.Core.nuget/FSharp.Core.nuspec
<group targetFramework=".NETStandard2.0">
<dependency id="NETStandard.Library" version="2.0.3" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to specify this dependency explicitly?

@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
@brettfo brettfo closed this May 20, 2019
@brettfo brettfo reopened this May 20, 2019
@brettfo brettfo closed this May 21, 2019
@KevinRansom KevinRansom mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@brettfo brettfo brettfo approved these changes

@dsyme dsyme Awaiting requested review from dsyme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @cartermp @brettfo