-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC FS-1060] Nullness checking #6804
Conversation
Failing tests:
|
@brettfo This has some weird error now for BuildFromSource on Linux, any ideas? I've not seen this before
|
There's an annoying failure in the Windows source build.
It doesn't reproduce for me on my windows machine when running this:
|
This PR has two failures
but I can't debug them. When I run these unit tests from the IDE they don't fail |
@dsyme I saw a similar failure in another merge, and from looking at it, those directories aren't on disk, so they may just need to be removed from a *.lst file. |
Ah of course, thank you!! Yes They are in |
@KevinRansom I assume you want this targeted at |
Heisenerror during testing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A merge brough back fcs
, src/utils/reshapredmsbuild
, net40 Fsharp.Core surface area tests, and likely more
Three remaining failures: fsharpqa:
fsharp:
|
Very happy to see this is now green again (which gives us opportunity to to iterate on it, instead of just maintaining it) |
Merge main to feature/nullness
Merge main to feature/nullness
Merge main to feature/nullness
I merged main into this but it is going to take quite a lot of work to get it compiling and green again :) |
I'll open a new PR for this |
Continuation of #5790
This is a prototype implementation of RFC FS-1060 nullable reference types
See
tests\fsharp\core\nullness\test.fsx
for testing and samples.TODO:
match x with null -> ... | x -> ...
implied use ofNonNull
patternnull
andNonNull
be considered disjunctive discriminators in pattern matching// TODO NULLNESS
Test ProjectForWitnesses4 GetWitnessPassingInfo
DONE:
Foo<string?>
, currentlyFoo< string? >
with a space between?
and>
is needed, need to token smash?>
token in tyargs