Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed uninitialized mutable locals inside loops #6899

Merged
merged 2 commits into from
May 31, 2019

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented May 29, 2019

Fixes this bug: #6895

We added an optimization in F# 4.6 that would stop initializing zero-init locals, such as, let mutable x = null but didn't account for the context, such as a recursive let binding, while loop, or a for loop.

@cartermp cartermp closed this May 30, 2019
@cartermp cartermp reopened this May 30, 2019
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@KevinRansom KevinRansom merged commit 00cbd3f into dotnet:release/dev16.2 May 31, 2019
@dsyme dsyme mentioned this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants