update version number for VS 16.3 #6991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Jun 12, 2019
| @@ -33,9 +33,6 @@ | |||
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\FSharp.Compiler.Private\FSharp.Compiler.Private.fsproj" /> | |||
| <ProjectReference Include="$(MSBuildThisFileDirectory)..\FSharp.Compiler.Interactive.Settings\FSharp.Compiler.Interactive.Settings.fsproj" /> | |||
|
|
|||
| <!-- only used when '$(TargetFramework)' == 'netstandard2.0' --> | |||
| <ProjectReference Include="..\FSharp.Build\FSharp.Build.fsproj" Condition="'$(TargetFramework)' == 'netstandard2.0'" /> | |||
There was a problem hiding this comment.
This was a merge error that hasn't been corrected for release/dev16.2 but came along for the ride during regular branch merges. $(TargetFramework) is never netstandard2.0 so it's a noop anyways.
cartermp
approved these changes
Jun 12, 2019
|
@brettfo 10.6. |
brettfo
force-pushed
the
dev16.3-versions
branch
from
c41a396 to
ca27f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not happening in this PR: updating the tools version from
10.5.0. Should it go to10.5.1or10.6.0? (@cartermp @KevinRansom)