Update several links #7055
Merged
Update several links #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Jun 24, 2019
DEVGUIDE.md
Outdated
| - We first need an existing F# compiler. We use the one in the `lkg` directory. Let's assume this compiler has an `FSharp.Core.dll` with version X. | ||
| - We use this compiler to compile the source in this distribution, to produce a "proto" compiler, dropped to the `proto` directory. When run, this compiler still relies on `FSharp.Core.dll` with version X. | ||
| - We use the proto compiler to compile the source for `FSharp.Core.dll` in this distribution. | ||
| s- We use the proto compiler to compile the source for `FSharp.Compiler.dll`, `fsc.exe`, `fsi.exe`, and other binaries found in this distribution. |
|
|
||
| * ``FSharp.Compiler.Service.MSBuild.v12`` adds legacy MSBuild v12 support to an instance of FSharp.Compiler.Service, if exact compatibility for scripting references such as ``#r "Foo, Version=1.3.4"`` is required. | ||
| - ``FSharp.Compiler.Service.MSBuild.v12`` adds legacy MSBuild v12 support to an instance of FSharp.Compiler.Service, if exact compatibility for scripting references such as ``#r "Foo, Version=1.3.4"`` is required. |
There was a problem hiding this comment.
it was a complaint of mdlint in Visual Studio Code, where I accepted the proposed change to get rid of it.
https://github.com/DavidAnson/markdownlint/blob/v0.15.0/doc/Rules.md#md004
| @@ -1,7 +1,7 @@ | |||
| // Learn more about F# at http://fsharp.org | |||
| // Learn more about F# at https://fsharp.org | |||
There was a problem hiding this comment.
Is there any actual benefits in updating the link in test data?
There was a problem hiding this comment.
not in the test data. In several other files are links to fsharp.org (I just found 87 references) so I decided to do a global search&replace for http://fsharp.org which included also the test data. Should do any harm there IMHO.
KevinRansom
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated several links and changed a lot of
http://...tohttps://...Further some mdlint warnings in markdowns are fixed.
I tried to give commit Messages which express what they contain.
Remark: In fcs\docsrc\content\index.md Projects using the F# Compiler Services are some links which were not reachable, namely