Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VS crash when inline IL is invalid #7167

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Jul 10, 2019

Resolves this issue: #7164

Basically, if any kind of error happens when trying to parse inline IL, then recover so the normal F# parsing continues.

The reason why it takes down VS is because when a failwith "parse error" occurs on parsing a file, while it will catch it, it will re-raise the exception because we want to report it as a watson; which then nothing handles it and takes down VS.

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@TIHan TIHan merged commit e057f09 into dotnet:release/dev16.3 Jul 10, 2019
@KevinRansom
Copy link
Member

@TIHan can you put this in master too, it will take quite a while until dev16.3 is merged back.

Thx

@TIHan
Copy link
Contributor Author

TIHan commented Jul 10, 2019

Sure

TIHan added a commit to TIHan/visualfsharp that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants