Fix VS crash when inline IL is invalid #7167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves this issue: #7164
Basically, if any kind of error happens when trying to parse inline IL, then recover so the normal F# parsing continues.
The reason why it takes down VS is because when a
failwith "parse error"
occurs on parsing a file, while it will catch it, it will re-raise the exception because we want to report it as a watson; which then nothing handles it and takes down VS.