Fix for issue #69 on github: units of measure metadata #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are pickled in a form compatible with F# 3.x tools. This is issue dotnet#69 on github.
|
|
||
| let rec p_measure_intpower unt n st = | ||
| match n with | ||
| | 0 -> p_byte 4 st |
There was a problem hiding this comment.
Duplicating "p_byte 4" is subtle. Factor out a new function called "p_measure_zero". And add a comment that "pbyte 4" is the F# canoncical encoding for MeasureZero.
|
This looks good, thanks for the fix! |
|
It works for me. |
added 2 commits
January 21, 2015 10:34
* Comments * Factored code a bit better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata for units that is produced by F# 4 cannot be read by F# 3.x tools, because the pickler uses a new form for MeasureRationalPower.
This fixes the problem by ensuring that any normalized unit expression whose exponents are all integers is pickled using the F# 3.x format.
This is issue #69 on github.