Release/fsharp47 #7301
Merged
Release/fsharp47 #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use 1-based column numbers in tests * Helper that can check for multiple type errors
…ev16.3 Merge master to release/dev16.3
…710.8 (dotnet#7200) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19360.8
…ev16.3 Merge master to release/dev16.3
* Remove semicolons from record tooltips * Update to put a space between braces * Update formatting as best I can, plus some tests I guess * More baseline updates * Anonymous records * Update anon records tests * Add vsbsl lol * Update baselines and reduce a simple filter * Update baselines maybe last time * Update fsharpqa test * make tests pass * Add formatting for values * Update tests * Update test * Update fsharpqa tests * tryit * lol * get yote * shlerp * Update tests again I guess * more update * mother of pearl * this is a real turd
cherrypick fix portable PDBs for anon records (dotnet#7099)
…ev16.3 Merge master to release/dev16.3
…711.7 (dotnet#7216) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19361.7
…712.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19362.5
…ev16.3 Merge master to release/dev16.3
…otnet#7221) Terminology and info regarding Supplementary Characters / Surrogate Pairs is either incorrect, or at least incomplete (which then leads to incorrect statements and/or code). 1. Introduce the term "Supplementary Character" since that is often what we are dealing with, not "surrogate pairs" since that is an encoding-specific concept (UTF-16 only). 2. Add comment re: Supplementary Character code point range, which helps to explain the `elif high > 0x10 then Invalid` condition (line 173). 3. Fix URI for Unicode Standard PDF, Chapter 3, and specify the name of the section (i.e. "Surrogates") instead of the section number (i.e. 3.8) since the section number was 3.7 but is now 3.8 (line 174). 4. Add comment for definition of a valid "surrogate pair" because why make the reader guess or have to go look it up when it will never change? (line 175) 5. Correct and expand comment with example long Unicode escape sequence (line 64): `"\UDEADBEEF"` is _not_ a valid escape sequence. Usage of the `\U` escape has been misstated from the very beginning, both in this documentation as well as the C# Specification documentation, and the language references for "String" for both F# and C#: 1. `\U` is used to specify a Unicode code point (or UTF-32 code unit, which maps 1:1 with all Unicode code points, hence they are synonymous), not surrogate pairs. Hence the valid range is `00000000` - `0010FFFF`, hence the first two digits are static `0`s, and the third digit can only ever be a `0` or `1`. This escape sequence can specify either a BMP character or a Supplementary character. Supplementary characters are then encoded as a surrogate pair in UTF-16 only, not in UTF-8 or UTF-32. If you want to specify an actual surrogate pair, then use the `\u` escape, e.g. `\uD83D\uDC7D` == `\U0001F47D`. 2. Even if you could specify a surrogate pair using `\U`, "DEADBEEF" is not valid. U+DEAD is a valid surrogate, _but_ it's a low surrogate code point and cannot be specified first in the pair (meaning, at best one could use `\UxxxxDEAD`). Also, U+BEEF is _not_ a valid surrogate code point, high or low. Surrogate code points are in the range of U+D800 to U+DFFF. For more info, please see: https://sqlquantumleap.com/2019/06/26/unicode-escape-sequences-across-various-languages-and-platforms-including-supplementary-characters/#fsharp
…ev16.3 Merge master to release/dev16.3
…-release/dev16.3 Merge release/fsharp47 to release/dev16.3
…4b9d-9933-89f867c6fb37 [master] Update dependencies from dotnet/arcade
* Moving AccessOfTypeAbbreviationTests over to NUnit * ha! now I know what this `1` means =) * Error range updated and removed `exit 0` * Error message prefixed by "This construct is deprecated." * Error messages changed based on current state of FSI
…ev16.3 Merge master to release/dev16.3
* Update dependencies from https://github.com/dotnet/arcade build 20190713.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19363.1 * Update dependencies from https://github.com/dotnet/arcade build 20190714.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19364.1
…715.4 (dotnet#7240) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19365.4
* Moving UpcastDowncastTests over to NUnit * missing new line
…716.4 (dotnet#7245) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19366.4
* Moving TypeMismatchTests over to NUnit * ci restart
Also publish native symbols so they can be archived later.
* Enable hash algorithm selection * Feedback * More feedback * Revert "Feedback" This reverts commit 6ab1b07. * feedback
…719.2 (dotnet#7260) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19369.2
* Improve netcore reference selection * Update baselines
* Moving Libraries Control tests to NUnit * Names tests as Async instead of Control
…722.10 (dotnet#7268) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19372.10
…master Merge release/dev16.2 to master
* fixes issue dotnet#6832 * Fix comment * Forgot to remove pdbs from fsharp.compiler.nuget * Rename Program.fs and exclude FSharpSdk from checks * Embedded doesn't need to verify tmp or obj directories. * typo * typo * Don't check FSharpSdk for hash * Make comment match code * Empty commit to force rebuild
* Update dependencies from https://github.com/dotnet/arcade build 20190723.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19373.6 * Update dependencies from https://github.com/dotnet/arcade build 20190724.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19374.2 * Update dependencies from https://github.com/dotnet/arcade build 20190725.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19375.2
…-release/dev16.3 Merge release/fsharp47 to release/dev16.3
…725.15 (dotnet#7282) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19375.15
…ev16.3 Merge master to release/dev16.3
* add test cases we need to make work * cleanup method call argument processing
…726.18 (dotnet#7285) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19376.18
* Moving ClassesTests over to NUnit * Fixed assertion for ParseWithErrors test
* Move BasicConstants.fs Tests To Nunit * fix typo * Another typo
* Update dependencies from https://github.com/dotnet/arcade build 20190727.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19377.2 * Update dependencies from https://github.com/dotnet/arcade build 20190728.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19378.1
…ev16.3 Merge master to release/dev16.3
brettfo
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge dev16.3 into release/fsharp47.