Fixed Literal value in signature #7901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
commented
Nov 23, 2019
TIHan
force-pushed
the
bug/literal-sig
branch
from
f9a26d0 to
75e2db5
Compare
|
I managed to do a one line fix for this without having to add any additional changes to the offside rules in the LexFilter. I now believe this is the correct approach and ready to merge. Normally I would use CompilerAssert for tests, but at the moment there is no such mechanism to test sig files; a new thing would need to be built on top it. So I decided that adding a simple test like we did with the other sigs is sufficient. |
TIHan
changed the title
|
@dsyme this should be pretty easy to review. |
KevinRansom
approved these changes
Nov 28, 2019
dsyme
approved these changes
Nov 28, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fixed literal sig from breaking subsequent sigs * Added tests for literal sig * Fixed test * Fixed test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this: #7897