Re-Implemented ILBinaryReader with System.Reflection.Metadata

src/absil/il.fs

@@ -2736,6 +2736,8 @@ let isILObjectTy ilg ty = isILBoxedBuiltInTy ilg ty tname_Object
 
 let isILStringTy ilg ty = isILBoxedBuiltInTy ilg ty tname_String
 
+let isILTypeTy ilg ty = isILBoxedBuiltInTy ilg ty tname_Type
+
 let isILTypedReferenceTy ilg ty = isILValueBuiltInTy ilg ty tname_TypedReference
 
 let isILSByteTy ilg ty = isILValueBuiltInTy ilg ty tname_SByte
@@ -3799,7 +3801,7 @@ type ILTypeSigParser (tstring : string) =
     //   Since we're only reading valid IL, we assume that the signature is properly formed
     //   For type parameters, if the type is non-local, it will be wrapped in brackets ([])
     //   Still needs testing with jagged arrays and byref parameters
-    member private x.ParseType() =
+    member x.ParseType() =
 
         // Does the type name start with a leading '['? If so, ignore it
         // (if the specialization type is in another module, it will be wrapped in bracket)
@@ -3898,6 +3900,11 @@ type ILTypeSigParser (tstring : string) =
         let ilty = x.ParseType()
         ILAttribElem.Type (Some ilty)
 
+type ILType with
+
+    static member Parse assemblyQualifiedName = 
+        (ILTypeSigParser assemblyQualifiedName).ParseType()
+
 let decodeILAttribData (ilg: ILGlobals) (ca: ILAttribute) =
     match ca with
     | ILAttribute.Decoded (_, fixedArgs, namedArgs) -> fixedArgs, namedArgs
@@ -3975,10 +3982,11 @@ let decodeILAttribData (ilg: ILGlobals) (ca: ILAttribute) =
             parseElems (v :: acc) (n-1) sigptr
           let elems, sigptr = parseElems [] n sigptr
           ILAttribElem.Array (elemTy, elems), sigptr
+      | ILType.Boxed _
       | ILType.Value _ -> (* assume it is an enumeration *)
           let n, sigptr = sigptr_get_i32 bytes sigptr
           ILAttribElem.Int32 n, sigptr
-      | _ -> failwith "decodeILAttribData: attribute data involves an enum or System.Type value"
+      | x -> failwithf "decodeILAttribData: attribute data involves an enum or System.Type value - boxity: %A type: %A" x.Boxity x
     let rec parseFixed argtys sigptr =
       match argtys with
         [] -> [], sigptr

src/absil/il.fsi

@@ -279,6 +279,8 @@ and
 
     member QualifiedName: string
 
+    static member Parse: assemblyQualifiedName: string -> ILType
+
 and [<StructuralEquality; StructuralComparison>]
     ILCallingSignature =  
     { CallingConv: ILCallingConv
@@ -1838,6 +1840,7 @@ val mkILCustomAttrsFromArray: ILAttribute[] -> ILAttributes
 val storeILCustomAttrs: ILAttributes -> ILAttributesStored
 val mkILCustomAttrsReader: (int32 -> ILAttribute[]) -> ILAttributesStored
 val emptyILCustomAttrs: ILAttributes
+val emptyILCustomAttrsStored: ILAttributesStored
 
 val mkILSecurityDecls: ILSecurityDecl list -> ILSecurityDecls
 val emptyILSecurityDecls: ILSecurityDecls
@@ -1981,6 +1984,7 @@ val isILIntPtrTy: ILGlobals -> ILType -> bool
 val isILUIntPtrTy: ILGlobals -> ILType -> bool
 val isILBoolTy: ILGlobals -> ILType -> bool
 val isILCharTy: ILGlobals -> ILType -> bool
+val isILTypeTy: ILGlobals -> ILType -> bool
 val isILTypedReferenceTy: ILGlobals -> ILType -> bool
 val isILDoubleTy: ILGlobals -> ILType -> bool
 val isILSingleTy: ILGlobals -> ILType -> bool