Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit compact IL code for unsigned 64-bit constants #8692

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Emit compact IL code for unsigned 64-bit constants #8692

merged 1 commit into from
Mar 11, 2020

Conversation

teo-tsirpanis
Copy link
Contributor

This PR essentially applies the fixes of #3620 to all 64-bit integers and thus closes #8683.

@dnfclas
Copy link

dnfclas commented Mar 10, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

TIHan
TIHan reviewed Mar 10, 2020
View reviewed changes
src/fsharp/IlxGen.fs Outdated Show resolved Hide resolved
TIHan
TIHan approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Seems reasonable to me considering we did it for Int64 already.

Approved pending the name change.

cartermp
cartermp approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the contribution @teo-tsirpanis

@cartermp cartermp merged commit 465d446 into dotnet:master Mar 11, 2020
@teo-tsirpanis teo-tsirpanis deleted the patch-3 branch March 11, 2020 08:25
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@teo-tsirpanis @nosami
Emit compact IL code for unsigned 64-bit constants (dotnet#8692)
32a4d53 
Closes dotnet#8683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@TIHan TIHan TIHan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uint64 literals generate suboptimal IL code
4 participants
@teo-tsirpanis @dnfclas @TIHan @cartermp