cleanup to minimize diff for RFC FS-1087 #8865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is also some improvement to debugging in the compiler with much improved DebugText for Expr and TOp values. THis helps speed debugger performance and I think prevents some stack overflow crashed suring debugging when formatting large expressions. |
|
If I could have an approve on this I'd be really grateful |
|
Replaced by #8867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the cleanup in #6811
The changes are cosmetic. The one change to values is in IlxGen.fs where it is cleaner to use a list for the "selfv" rather than an option in some places and a list in another. But that is also a cosmetic change as it's easy to verify that the list always contains 0 or 1 elements here.