-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorg solution file #893
reorg solution file #893
Conversation
maybe we can also show a clean cut between FSharp.Core (a library) and the compiler, |
Wow this way looks so much better! 👍 |
Fine for me |
Pulling after discussing with @KevinRansom. Microsoft still has an internal build process used to package the Visual F# Tools which is separate to the process used here, and this PR might affect that because the test DLLs are being renamed. But we think that the test DLLs no longer need to be built as part of that. In any case a big thanks to @KevinRansom in advance for dealing with any fallout of this w.r.t. the internal Microsoft build process (a pain point we hope will go away by moving to purely external build process eventually) |
@@ -1,172 +0,0 @@ | |||
// Copyright (c) Microsoft Open Technologies, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsyme why this file is deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was not included in any active testing. It's duplicated in LazyType.fs, and in any case the type is part of the .NET Fx and tested there
@dsyme some test file are deleted, it's intentional (duplicated) or an error? |
Yes, intentional, see comments above, thanks for checking! |
I just wanted to mention that I found the VisualFSharp.sln file much easier to work with this evening because of this PR - I could actually find the necessary code and the appropriate unit tests! :) Cleanup which makes it easier to contribute is really important... |
This renames
It also
The aim is to make it easier to contribute to the Visual F# Tools by improving the organization of things. The visual appearance of VisualFSharp.sln is shown below