Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg solution file #893

Merged
merged 7 commits into from
Jan 27, 2016
Merged

reorg solution file #893

merged 7 commits into from
Jan 27, 2016

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jan 25, 2016

This renames

.\vsintegration\src\Deployment.sln --> .\VisualFSharp.sln
Salsa.dll --> VisualFSharp.Salsa.dll
Unittests.dll --> VisualFSharp.Unittests.dll

It also

  • adds a couple of virtual folders to VisualFSharp.dln (was called Deployment.sln)
  • removes a couple of test files that weren't being referenced anywhere

The aim is to make it easier to contribute to the Visual F# Tools by improving the organization of things. The visual appearance of VisualFSharp.sln is shown below

capture

@enricosada
Copy link
Contributor

maybe we can also show a clean cut between FSharp.Core (a library) and the compiler,

@dsyme
Copy link
Contributor Author

dsyme commented Jan 25, 2016

OK done, please see below

capture

@rodrigovidal
Copy link

Wow this way looks so much better! 👍

@enricosada
Copy link
Contributor

Fine for me

@dsyme
Copy link
Contributor Author

dsyme commented Jan 27, 2016

Pulling after discussing with @KevinRansom. Microsoft still has an internal build process used to package the Visual F# Tools which is separate to the process used here, and this PR might affect that because the test DLLs are being renamed. But we think that the test DLLs no longer need to be built as part of that.

In any case a big thanks to @KevinRansom in advance for dealing with any fallout of this w.r.t. the internal Microsoft build process (a pain point we hope will go away by moving to purely external build process eventually)

dsyme added a commit that referenced this pull request Jan 27, 2016
@dsyme dsyme merged commit 1bbc360 into dotnet:master Jan 27, 2016
@@ -1,172 +0,0 @@
// Copyright (c) Microsoft Open Technologies, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsyme why this file is deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was not included in any active testing. It's duplicated in LazyType.fs, and in any case the type is part of the .NET Fx and tested there

@enricosada
Copy link
Contributor

@dsyme some test file are deleted, it's intentional (duplicated) or an error?

@dsyme
Copy link
Contributor Author

dsyme commented Jan 27, 2016

Yes, intentional, see comments above, thanks for checking!

@dsyme
Copy link
Contributor Author

dsyme commented Feb 6, 2016

I just wanted to mention that I found the VisualFSharp.sln file much easier to work with this evening because of this PR - I could actually find the necessary code and the appropriate unit tests! :)

Cleanup which makes it easier to contribute is really important...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants