Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xmldoc about Seq.rev consume input sequence #903

Merged
merged 3 commits into from
Jan 28, 2016

Conversation

enricosada
Copy link
Contributor

ref #902

phrase is ok?

@@ -957,6 +957,7 @@ namespace Microsoft.FSharp.Collections
/// <param name="source">The input sequence.</param>
/// <returns>The reversed sequence.</returns>
/// <exception cref="System.ArgumentNullException">Thrown when the input sequence is null.</exception>
/// <remarks>Consume the whole input sequence before yielding the first element.</remarks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest

This function consumes the whole input sequence before yielding the first element of the reversed sequence.

@enricosada
Copy link
Contributor Author

used @dsyme phrase

@enricosada
Copy link
Contributor Author

others function who consume the whole input? /cc @vasily-kirichenko @forki @kolektiv

@forki
Copy link
Contributor

forki commented Jan 27, 2016

@7sharp9 identified: sort, foldBack, reduceBack, tryFindBack, findBack, scanBack, tryFindIndexBack, findIndexBack, sortWith, permute, mapFold, mapFoldBack, splitinto

@enricosada
Copy link
Contributor Author

*Back it's ok
*reduce, *fold, sort, scan ok

but splitInto too? why? /cc @7sharp9 nvm i was thinking about chunkInto

@enricosada enricosada changed the title add xmldoc about Seq.rev consume input sequence [WIP] add xmldoc about Seq.rev consume input sequence Jan 27, 2016
…k, tryFindIndexBack, findIndexBack, sortWith, permute, mapFold, mapFoldBack, splitinto
@enricosada enricosada changed the title [WIP] add xmldoc about Seq.rev consume input sequence add xmldoc about Seq.rev consume input sequence Jan 28, 2016
@enricosada
Copy link
Contributor Author

added the other functions, thx @forki and @7sharp9 .
@dsyme pharse are ok?

@dsyme
Copy link
Contributor

dsyme commented Jan 28, 2016

This looks fine. Since it's just XML documentation I will merge it.

dsyme added a commit that referenced this pull request Jan 28, 2016
add xmldoc about Seq.rev consume input sequence
@dsyme dsyme merged commit a458989 into dotnet:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants