Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version numbers #9260

Merged
merged 4 commits into from
May 27, 2020
Merged

Conversation

KevinRansom
Copy link
Member

FSharp.Core 4.7.2 is now published, time to prepare 4.7.3

Update tooling version numbers to prepare to 4.9.2

@KevinRansom KevinRansom requested a review from brettfo May 22, 2020 07:22
<!-- The pattern for specifying the preview package -->
<FSharpCorePreviewPackageVersion>$(FSCorePackageVersion)-$(PreReleaseVersionLabel).*</FSharpCorePreviewPackageVersion>
</PropertyGroup>
<PropertyGroup>
<FSPackageMajorVersion>10.8</FSPackageMajorVersion>
<FSPackageVersion>$(FSPackageMajorVersion).1</FSPackageVersion>
<FSPackageMajorVersion>10.9</FSPackageMajorVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in this pr, I'll come in with the merge from 16.6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I just pulled in the 16.6 -> master merge, so the 10.9 change and the .2 change can be pulled out of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kewl

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettfo , done.

<!-- The pattern for specifying the preview package -->
<FSharpCorePreviewPackageVersion>$(FSCorePackageVersion)-$(PreReleaseVersionLabel).*</FSharpCorePreviewPackageVersion>
</PropertyGroup>
<PropertyGroup>
<FSPackageMajorVersion>10.9</FSPackageMajorVersion>
<FSPackageVersion>$(FSPackageMajorVersion).1</FSPackageVersion>
<FSPackageVersion>$(FSPackageMajorVersion).2</FSPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.9.1 should probably change to 10.10.0 instead of 10.9.2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettfo, done.

@KevinRansom KevinRansom merged commit 977d0ac into dotnet:master May 27, 2020
@KevinRansom KevinRansom deleted the updatefsharp.core branch June 3, 2020 20:09
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Update version

* Update Versions.props

* Update Versions.props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants