Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating #6810 into #6811 a regression turned up. This trials the likely fix for it
The problem lies in the fact that an extra constraint is being asserted during optimization. The relevant lines of #6810 are things like this and [this]. The tril fix disables one of these lines during optimization.
However I need to do further analysis for why these lines were needed. Extra constraints should not need to be asserted and it is possile that this call to 'freshen' ultimately meant the other two changes where not needed.
Note the regression is active even if
langversion
is not set, which also indicates some inaccurate coding in #6810