Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] trial fix for 9449 #9455

Closed
wants to merge 1 commit into from
Closed

[WIP] trial fix for 9449 #9455

wants to merge 1 commit into from

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 15, 2020

While integrating #6810 into #6811 a regression turned up. This trials the likely fix for it

The problem lies in the fact that an extra constraint is being asserted during optimization. The relevant lines of #6810 are things like this and [this]. The tril fix disables one of these lines during optimization.

However I need to do further analysis for why these lines were needed. Extra constraints should not need to be asserted and it is possile that this call to 'freshen' ultimately meant the other two changes where not needed.

  • check if this fix is green
  • more analysis needed and trial possible alternative fixes
  • add testing around the regression

Note the regression is active even if langversion is not set, which also indicates some inaccurate coding in #6810

@dsyme dsyme mentioned this pull request Jun 15, 2020
1 task
@dsyme
Copy link
Contributor Author

dsyme commented Jun 16, 2020

Closing as #9456 is a better fix

@dsyme dsyme closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant