Refactor packagemanager lines #9701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
refactorpoundr
branch
from
63e0aa4 to
14cf809
Compare
cartermp
reviewed
Jul 22, 2020
cartermp
approved these changes
Jul 23, 2020
brettfo
approved these changes
Jul 23, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Refactor packagemanager lines * fix add * Fix merge issues * feedback Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add support for #i, first I have done some refactoring around packagemanager lines.
The updates include a discriminator indicating #i or #r , although perhaps a discriminated union would work better.
And adds a few utility helpers to PackageManagerLine to manage the maps.