Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of cross-version tests #990

Merged
merged 2 commits into from
Mar 2, 2016

Conversation

latkin
Copy link
Contributor

@latkin latkin commented Feb 29, 2016

Now that the compiler copies FSharp.Core.dll locally by default, the cross-version tests are passing somewhat by accident. They will fail if you run them outside of the Perl test runner - they only pass because the dummy.fs compile caused an initial copy-local that happens to make things work.

This is a small change that makes things more robust/explicit/intentional.

  • Explicitly copy the desired FSharp.Core version locally before invoking the test exe
    • Ensures resolution is fully controlled for both new and old compiler versions
  • Delete any local FSharp.Core copies before invoking FSI
    • Old FSI crashes on startup if FSharp.Core 4.4.0.0 is in the local directory due to "can't find sigdata/optdata" error

Also went ahead and removed 2 excluded test scenarios which now work post- F# 4.0

@latkin
Copy link
Contributor Author

latkin commented Feb 29, 2016

Motivation for this was problems I hit while adding some tests for the struct records PR

@KevinRansom
Copy link
Member

Nice ... I'm glad to have you around Lincoln.

@dsyme
Copy link
Contributor

dsyme commented Mar 2, 2016

Looks good, we can accept this

@dsyme
Copy link
Contributor

dsyme commented Mar 2, 2016

I'll merge since it's a testing issue

dsyme added a commit that referenced this pull request Mar 2, 2016
@dsyme dsyme merged commit f7503c2 into dotnet:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants