Fix Out/Error streams chunking in Fsi tool window #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864
The issue is that chunking the output streams (standard output and error) was done in order:
Per the previous chunking function, this produced chunks of [(1), (2), (3,4)], and the following output (notice that the prompt is after the first line):
The new chunking function groups across lines, producing chunks of [(1,3,4), (2)], and the following output (the prompt is now separate from error lines):
@dsyme @abelbraaksma @Microsoft/fsharp-compiler