ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failu…

…re (#103) Backport of unicode-org/icu#1699
dotnet · Apr 19, 2021 · f8d1ccb · f8d1ccb
1 parent 58af26e
commit f8d1ccb
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/icu/icu4c/source/i18n/smpdtfmt.cpp b/icu/icu4c/source/i18n/smpdtfmt.cpp
@@ -4262,11 +4262,9 @@ SimpleDateFormat::tzFormat(UErrorCode &status) const {
  {
  if (fTimeZoneFormat == NULL) {
  TimeZoneFormat *tzfmt = TimeZoneFormat::createInstance(fLocale, status);
- if (U_FAILURE(status)) {
- return NULL;
+ if (U_SUCCESS(status)) {
+ const_cast<SimpleDateFormat *>(this)->fTimeZoneFormat = tzfmt;
  }
-
- const_cast<SimpleDateFormat *>(this)->fTimeZoneFormat = tzfmt;
  }
  }
  umtx_unlock(LOCK());