Skip to content

Upgrade main to ICU-72 from dotnet/test/icu72-main #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 12, 2023
Merged

Upgrade main to ICU-72 from dotnet/test/icu72-main #340

merged 7 commits into from
Apr 12, 2023

Conversation

@steveisok
Copy link
Member

@steveisok steveisok commented Mar 29, 2023

No description provided.

@steveisok
Copy link
Member Author

steveisok commented Apr 5, 2023

@akoeplinger @directhex can one or both review / approve? I'd like to get this through so it can be more thoroughly tested in runtime.

@akoeplinger
Copy link
Member

akoeplinger commented Apr 5, 2023 •
edited
Loading

There are a few issues but GitHub fails if I try to comment on them in the PR diff view 😄

  1. You're reverting the changes from 731657f

  2. docs, icu4j and vendor/double-conversion folders are added back. also some folders in tools that we don't need

  3. The CODE_OF_CONDUCT.md and SECURITY.md were deleted

  4. The pom.xml in icu/tools/cldr/clrd-to-icu and lib directories wasn't moved to the new location. We modified it to please some security scanner. We should turn those changes into a patch file that we apply.

    Hmm or maybe we don't need the tools/cldr folder at all? Afaik we just kept it because it was in the microsoft/icu fork. We could try deleting it.

@lewing
Copy link
Member

lewing commented Apr 11, 2023

are we trying to get this in for p4?

@steveisok
Copy link
Member Author

steveisok commented Apr 11, 2023

are we trying to get this in for p4?

yes

Steve Pfister and others added 3 commits April 11, 2023 17:26
Chop unnecessary folders
9489936
@akoeplinger
Bump iOS/tvOS min version to 11, remove 32bit targets and remove bitc…
934e4b7 
…ode from tvOS (dotnet#318)

* Bump iOS min version to 11, remove 32bit targets and remove bitcode from tvOS

We did the same in dotnet/runtime with dotnet/runtime#79349 and dotnet/runtime#81965

* Fixup
Add back files
8d4d78e
@steveisok
Copy link
Member Author

steveisok commented Apr 11, 2023 •
edited
Loading

Hmm or maybe we don't need the tools/cldr folder at all? Afaik we just kept it because it was in the microsoft/icu fork. We could try deleting it.

Seems to build fine w/o both tools and lib folders, so I deleted them.

@akoeplinger
Copy link
Member

akoeplinger commented Apr 12, 2023

Found one more missing and pushed it, looks good now.

@steveisok steveisok merged commit 89d559f into dotnet:dotnet/main Apr 12, 2023
@steveisok steveisok deleted the upgrade-icu-72 branch April 12, 2023 14:54
directhex added a commit to directhex/icu that referenced this pull request May 26, 2023
@directhex
Revert "Upgrade main to ICU-72 from dotnet/test/icu72-main (dotnet#340)"
ac05081 
This reverts commit 89d559f.
steveisok pushed a commit that referenced this pull request May 26, 2023
@directhex
Revert "Upgrade main to ICU-72 from dotnet/test/icu72-main (#340)" (#353
b2c0d51 
)

This reverts commit 89d559f.
ilonatommy added a commit that referenced this pull request Oct 29, 2025
@ilonatommy
Revert "Revert "Upgrade main to ICU-72 from dotnet/test/icu72-main (#340
ee56798 
)" (#353)"

This reverts commit b2c0d51.
This was referenced Oct 29, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@directhex directhex Awaiting requested review from directhex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steveisok @akoeplinger @lewing