Special functions testing improvements, NormalCdfLn bugfix. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tminka
approved these changes
Apr 7, 2020
tminka
approved these changes
Apr 8, 2020
tminka
approved these changes
Apr 8, 2020
tminka
pushed a commit
to kant2002/infer
that referenced
this pull request
Aug 24, 2020
- Moved arguments and expected result values for special function tests from inlined code to csv files. - Added a python script to compute expected result values for tested special functions in high precision. - Improved accuracy of NormalCdfLn for `x < -8`. Truncated series was too short, test used to pass, because the expected value itself was incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x < -8. Truncated series was too short, test used to pass, because the expected value itself was incorrect.