Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special functions improvements #253

Merged
merged 16 commits into from
May 27, 2020
Merged

Special functions improvements #253

merged 16 commits into from
May 27, 2020

Conversation

msdmkats
Copy link
Contributor

  • Ensured argument consistency in NormalCdfIntegralTest
  • Fixed some test values
  • Exp-Sinh quadrature in LogisticGaussian
  • Arithmetic-precision-based constants in logistic gaussian
  • Named const for Ulp(1)
  • Generating series for gamma(x) - 1/x
  • Fixed integer overflow in BGRat
  • GenerateSeries can print arrays of bigfloats.

Dmitry Kats added 15 commits May 27, 2020 11:36
GenerateSeries can print arrays of bigfloats.
a461880
Printing more coefficient arrays as bigfloats.
5b29de7
Allow more iterations for normal cdf ratio continued fraction converg…
de4c6ff 
…ence
Constant for default Beta precision
0de3bf6
Fixed integer overflow in BGRat
375fbb6
Added a comment to BGRat
4185afa
Generating series for gamma(x) - 1/x
3038229
Named const for Ulp(1), use autogenerated series in GammaSeries
362de28
Extra iterations in normalCdfRatio; named constant for confrac tolerance
fea2241
Print bigfloat coefficients for ((exp(x) - 1) / x - 1) / x - 0.5
78c0dfb
Arithmetic-precision-based constants in logistic gaussian
a60b2c4
Ulp1-based constants and exp-sinh quadrature in logisticGaussian
60cf33d
Fix test values
8f029da
Fix test values for ncdfln2
c0c2266
Ensured argument consistency in NormalCdfIntegralTest
e16409f
@msdmkats msdmkats requested a review from tminka May 27, 2020 09:43
tminka
tminka approved these changes May 27, 2020
View reviewed changes
@msdmkats msdmkats merged commit c6f896c into master May 27, 2020
@msdmkats msdmkats deleted the dmkats/updates branch May 27, 2020 15:19
tminka pushed a commit to kant2002/infer that referenced this pull request Aug 24, 2020
@msdmkats @tminka
Special functions improvements (dotnet#253)
bce63e8 
- Ensured argument consistency in NormalCdfIntegralTest
- Fixed some test values
- Exp-Sinh quadrature in LogisticGaussian
- Arithmetic-precision-based constants in logistic gaussian
- Named const for Ulp(1)
- Generating series for gamma(x) - 1/x
- Fixed integer overflow in BGRat
- GenerateSeries can print arrays of bigfloats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tminka tminka tminka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msdmkats @tminka