dotnet-install.sh fails when dot-sourced from the command line

[JayBazuzi]

• This issue is blocking
• This issue is causing unreasonable pain

On a Mac running ZSH:

> . dotnet-install.sh   
(eval):1: FUNCNAME[0]: parameter not set
(eval):1: FUNCNAME[0]: parameter not set

and then my shell closes, ouch!

[MichalPavlik]

I can repro using zsh 5.8 (x86_64-ubuntu-linux-gnu)

[MichalPavlik]

I think I know the reason. The script instructs shell to exit if an unset variable is encountered (via set -u). The FUNCNAME[0] located here:

install-scripts/src/dotnet-install.sh

Line 15 in 033622c

invocation='say_verbose "Calling: ${yellow:-}${FUNCNAME[0]} ${green:-}$*${normal:-}"'

is a Bash specific thing. ZSH uses funcstack, but I'm not sure why it fails only when dot-sourced.

[baronfel]

I think we shouldn't support funcstack or other Zsh-isms by design - the shebang specifically calls out that this is a bash script, not a Zsh-compatible script.

[JayBazuzi]

It's not completely clear-cut, @baronfel:

• Dot-sourcing ignores the shebang, so the fact that it says #!/usr/bin/env bash is an internal detail that has no effect.
• Mac now defaults to Zsh, so it's gonna happen even to people who don't consciously choose their shell.
• The file name extension is .sh (if it was .bash that would explicitly say it's for Bash.)

[splatteredbits]

Why would you dot source the script instead of just executing/running it?

> ./dotnet-install.sh

[JayBazuzi]

Why would you dot source the script instead of just executing/running it?

./dotnet-install.sh

install-scripts/src/dotnet-install.sh

Line 1874 in a450dd5

say "Adding to current process PATH: \`$bin_path\`. Note: This change will be visible only when sourcing script."