SH doesn't correctly grab global.json sdk version

[jbobo]

https://dotnet.microsoft.com/download/dotnet-core/scripts/v1/dotnet-install.sh when run as bash ./dotnet-install.sh --jsonfile ./global.json grabs everything in sdk after version instead of only grabbing the sdk.version value.

Example of global.json:

{
  "sdk": {
    "version": "3.1",
    "allowPrerelease": false,
    "rollForward": "latestPatch"
  }
}

error:

dotnet-install: Downloading link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1allowPrerelease:falserollForward:latestPatch/dotnet-sdk-3.1allowPrerelease:falserollForward:latestPatch-linux-x64.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1allowPrerelease:falserollForward:latestPatch/dotnet-sdk-3.1allowPrerelease:falserollForward:latestPatch-linux-x64.tar.gz
dotnet-install: Downloading legacy link: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1allowPrerelease:falserollForward:latestPatch/dotnet-dev-centos-x64.3.1allowPrerelease:falserollForward:latestPatch.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
dotnet-install: Cannot download: https://dotnetcli.azureedge.net/dotnet/Sdk/3.1allowPrerelease:falserollForward:latestPatch/dotnet-dev-centos-x64.3.1allowPrerelease:falserollForward:latestPatch.tar.gz
dotnet_install: Error: Could not find/download: `.NET Core SDK` with version = 3.1allowPrerelease:falserollForward:latestPatch
dotnet_install: Error: Refer to: https://aka.ms/dotnet-os-lifecycle for information on .NET Core support

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: a2e484a9-5e0c-eb3e-1413-7b507c4fa07d
• Version Independent ID: 5bc7caa5-f1c2-d7d5-fe02-80c65cca9672
• Content: dotnet-install scripts - .NET Core CLI
• Content Source: docs/core/tools/dotnet-install-script.md
• Product: dotnet-core
• Technology: dotnet-cli
• GitHub Login: @tdykstra
• Microsoft Alias: tdykstra

[tdykstra]

@wli3 who can help with this?

[wli3]

@donJoseLuis

Although I don't think this is a high priory issue. Considering we want to move majority of the logic out of the bash script (to some programming language more maintainable). Once we have that, we can share logic with SDK resolver for this logic

[bekir-ozturk]

We haven't been able to fix the issues with failing builds yet, so we don't have the availability to work on this issue now. Please track the progress of the current issue we are working here: dotnet/sdk#11320

[kondratyev-nv]

It looks like the issue can be fixed by removing the line https://github.com/dotnet/install-scripts/blob/master/src/dotnet-install.sh#L471

sdk_list="$(echo -e "${sdk_list}" | tr -d '[[:space:]]')"

On macOS, echo does not have a -e argument, so all lines of key-value pairs in sdk_list are merged into a single line. Removing it seems to fix it.

I've already created a PR in sdk repo - dotnet/sdk#12339, as I thought that was the right place to fix it. All tests are passed and I've added more tests to reproduce the issue there.

I can create a similar PR in the install-scripts repo. However, ./build.sh from the root of the repo throws and error, and I don't see tests (as in https://github.com/dotnet/sdk/blob/master/src/Tests/InstallationScript.Tests/GivenThatIWantToInstallTheSdkFromAScript.cs) to make sure that changes are working. If anyone can suggest a way to build this repo and test the changes I would be happy to open a PR.