Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of the script by default #356

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Mar 7, 2023

Add the script's purpose to the help text

Resolves #351

Before

image

After

image
image
image

@MichalPavlik
Copy link
Member

Hey @RussKie, thanks for the PR. Could you please also modify tests. It seems some of them are expecting to have removed text in stdout.

* Add the script's purpose to the help text

* Add config to allow debugging WSL from VS
See https://learn.microsoft.com/visualstudio/test/remote-testing

* Update Verify to latest that supports debugging in WSL
See https://github.com/VerifyTests/Verify#unit-testing-inside-virtualized-environment

Resolves dotnet#351
@RussKie RussKie force-pushed the fix_351_reduce_verbosity branch from a24620c to 12e667c Compare March 10, 2023 03:58
@RussKie
Copy link
Member Author

RussKie commented Mar 10, 2023

Tests amended, new added. Should be good to go now.
Thanks.

@MichalPavlik MichalPavlik merged commit 0b09de9 into dotnet:main Mar 10, 2023
@RussKie RussKie deleted the fix_351_reduce_verbosity branch May 1, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-dotnet.ps1 is too verbose without way to quiet it
3 participants