Skip to content

Removing dependencies check, adding a link to documentation page #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

AR-May
Copy link
Member

@AR-May AR-May commented Oct 27, 2020

Concerns issues #6, #36, #72.

The dependencies check is currently broken:

  • it is out of date,
  • it is not full (and can't be full): for different versions, for runtime/SDK, there might be different sets of dependencies,
  • the warnings are misleading, as they do not specify that it is a library name, not a package name, which has not been found.

To support these checks properly (more/less full and not out of date) we would need too big of an effort. It is doubtful that some checks always are better than none: we are worried that the customer would see the warning, add the library, and would not understand why dotnet still does not work, as a result of incompleteness of a check.

Based on these, we decided to remove them and instead always ask the customer to visit the documentation page and to check the dependencies listed there.

Copy link
Contributor

@donJoseLuis donJoseLuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this forward. We definitely need @bozturkMSFT 's signoff.

Copy link

@genalt genalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AR-May AR-May self-assigned this Oct 28, 2020
…dding a message with the link to documentation page
@AR-May AR-May force-pushed the update-pre-reqs-in-warnings branch from 55b4301 to 2e43198 Compare October 29, 2020 12:59
@AR-May AR-May merged commit ad55554 into dotnet:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants