Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #10770

Merged
merged 18 commits into from
May 26, 2021
Merged

Spelling #10770

merged 18 commits into from
May 26, 2021

Conversation

jsoref
Copy link

@jsoref jsoref commented May 26, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@ff32577#commitcomment-51320921

The action reports that the changes in this PR would make it happy: jsoref@cbf283e

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

jsoref added 18 commits May 26, 2021 05:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@marcpopMSFT marcpopMSFT merged commit 789b3b0 into dotnet:main May 26, 2021
@jsoref jsoref deleted the spelling branch May 26, 2021 21:31
@jsoref
Copy link
Author

jsoref commented May 28, 2021

Thanks @marcpopMSFT. If you're interested in the action, I'd be happy to contribute it. It's good at preventing typos from creeping back into repositories. (Happy to private @ microsoft references.)

n.b. I don't expect to offer a PR to dotnet/runtime anytime soon. It took 2 nights to do dotnet/winforms -- which is for a <10min analysis on a clone that's ~180mb. Whereas the clone of runtime is 1.5gb and analysis took >3 hours. I already have a queue of things in this category and am slowly working on a single repo (plus, realistically, the winforms PR is about as large as someone can review, so anything larger would require negotiation w/ a project in advance -- that said, if a project asked, I'd prioritize it).

@marcpopMSFT
Copy link
Member

Thanks for the contribution. @terrajobst tends to manage the various dotnet repos and so he might be interested in a broader policy around spell checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants